Refactor writable warm feature flag to include tiering #13719
Conversation
neetikasinghal
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
|
❌ Gradle check result for c5a775e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/common/settings/FeatureFlagSettings.java
Outdated
Show resolved
Hide resolved
neetikasinghal
force-pushed
the
ff-refactor
branch
from
c5a775e
to
6e9632c
Compare
|
❌ Gradle check result for 6e9632c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
server/src/main/java/org/opensearch/common/util/FeatureFlags.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
neetikasinghal
force-pushed
the
ff-refactor
branch
from
6e9632c
to
756e26a
Compare
|
❌ Gradle check result for 756e26a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
|
❕ Gradle check result for 756e26a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13719 +/- ##
============================================
+ Coverage 71.42% 71.52% +0.10%
- Complexity 59978 61221 +1243
============================================
Files 4985 5062 +77
Lines 282275 287907 +5632
Branches 40946 41692 +746
============================================
+ Hits 201603 205928 +4325
- Misses 63999 64990 +991
- Partials 16673 16989 +316 ☔ View full report in Codecov by Sentry. |
Created tracking issue for new flaky test: #13797. Other one is known: #13307 |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13719-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da0cf847a3639b45efc34b211854284ecf00ef8d
# Push it to GitHub
git push --set-upstream origin backport/backport-13719-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
…oject#13719) Signed-off-by: Neetika Singhal <neetiks@amazon.com>
Description
Refactor the writable remote index feature flag to include the tiering functionality as well. Considered the following options:
Related Issues
Resolves #13718
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.